Skip to content

Test new features in more places #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

szegedi
Copy link

@szegedi szegedi commented Jul 2, 2025

What does this PR do?:
Enables async ID collection and CPED storage of sample contexts in more tests.

Motivation:
We want the features to run as widely as possible in tests. We enable them in worker tests (although we don't check the results – we mostly want to make sure there are no crashes) and also in the larger label testing in test-time-profiler.ts

How to test the change?:
It's all tests.

Copy link

github-actions bot commented Jul 2, 2025

Overall package size

Self size: 1.63 MB
Deduped: 2 MB
No deduping: 2 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.4 | 226 kB | 226 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi added the semver-patch Bug or security fixes, mainly label Jul 2, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jul 2, 2025

Benchmarks

Benchmark execution time: 2025-07-04 12:29:49

Comparing candidate commit f9a66d5 in PR branch szegedi/more-async-id-tests with baseline commit 50d816d in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 89 metrics, 28 unstable metrics.

scenario:profiler-idle-with-wall-profiler-18

  • 🟩 cpu_user_time [-7.793ms; -2.792ms] or [-10.620%; -3.805%]

scenario:profiler-light-load-no-wall-profiler-24

  • 🟩 cpu_user_time [-9.931ms; -2.970ms] or [-12.484%; -3.734%]

scenario:profiler-light-load-with-wall-profiler-20

  • 🟩 cpu_user_time [-11.245ms; -3.136ms] or [-10.632%; -2.966%]

@szegedi szegedi changed the title Test async ID collection in more places Test new features in more places Jul 4, 2025
@szegedi szegedi force-pushed the szegedi/more-async-id-tests branch from 4e02891 to 49d022a Compare July 16, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug or security fixes, mainly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant